Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place 'r' prefix before 'f' for raw format strings #8464

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

deepyaman
Copy link
Contributor

Summary

Currently, UP032 applied to raw strings results in format strings with the prefix 'fr'. This gets changed to 'rf' by Ruff format (or Black). In order to avoid that, this PR uses the prefix 'rf' to begin with.

Test Plan

Updated the expectation on an existing test.

@deepyaman deepyaman marked this pull request as ready for review November 3, 2023 05:29
Copy link
Contributor

github-actions bot commented Nov 3, 2023

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@charliermarsh charliermarsh self-assigned this Nov 3, 2023
@charliermarsh
Copy link
Member

Thanks, that's a great idea. I'll review and merge this later today.

Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@charliermarsh charliermarsh merged commit f56bc19 into astral-sh:main Nov 3, 2023
17 checks passed
@charliermarsh
Copy link
Member

Thanks for getting involved! Great PR.

@charliermarsh charliermarsh added the bug Something isn't working label Nov 3, 2023
@deepyaman deepyaman deleted the fix/rf-not-fr branch November 3, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants