Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flake8-debugger #909

Merged
merged 6 commits into from
Nov 26, 2022
Merged

Conversation

karpa4o4
Copy link
Contributor

No description provided.

@karpa4o4
Copy link
Contributor Author

@charliermarsh, hi. I tried to bring the logic as close to the original as possible, but in debugger_call it was not completely successful. I will be glad to receive feedback.

@charliermarsh
Copy link
Member

Awesome! Will review this shortly. Thanks for putting this together.

@charliermarsh
Copy link
Member

@karpa4o4 - I did some small refactors to use match_call_path and friends, which are some utilities we have to do this kind of "Is a function call an invocation of a specific member, in a specific module?" logic.

@charliermarsh charliermarsh merged commit 721a1e9 into astral-sh:main Nov 26, 2022
@charliermarsh
Copy link
Member

But let me know if I messed anything up please :)

@karpa4o4 karpa4o4 deleted the add-flake8-debugger branch November 26, 2022 21:44
@karpa4o4
Copy link
Contributor Author

@charliermarsh, thanks. Sorry, I forgot to write "Closed" in the pull request description. So issue #546 stays open.
Can I help with the implementation of some other rule?

@charliermarsh
Copy link
Member

Oh good catch! Just closed the issue.

Can I help with the implementation of some other rule?

Definitely! There's a bunch of unclaimed stuff in #827, if you're interested in those? Alternatively, there's #458 but it's a bit more involved as I'd like it to be integrated with some of the existing docstring checks.

@charliermarsh
Copy link
Member

Oh, or #870 -- we only need the first rule (U100). It'd probably look like the implementation we have for unused_variables, but we have to check for BindingKind::Argument.

@karpa4o4
Copy link
Contributor Author

@charliermarsh, hi. Unfortunately I could not do the issues that you described above. But now I want to participate in the development of ruff again, can you tell me how I can help?

@charliermarsh
Copy link
Member

charliermarsh commented Jan 21, 2023

No worries! If you're interested, you could consider working on the tryceratops plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants