Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the keyring provider to allow testing #2980

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Apr 10, 2024

An adaptation of the proposal in #2570

Part of #2976 and #2984

@zanieb zanieb added the internal A refactor or improvement that is not user-facing label Apr 10, 2024
@zanieb zanieb marked this pull request as ready for review April 11, 2024 00:18
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@zanieb zanieb merged commit 072426e into zb/refactor-auth-store Apr 11, 2024
37 checks passed
@zanieb zanieb deleted the zb/refactor-keyring-provider branch April 11, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal A refactor or improvement that is not user-facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants