-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): bump rust toolchain to 1.81 #1523
base: main
Are you sure you want to change the base?
Conversation
8415675
to
9142701
Compare
c084b23
to
c751c24
Compare
cb99f5b
to
4852565
Compare
4852565
to
f32e820
Compare
@@ -13,6 +13,8 @@ on: | |||
env: | |||
REGISTRY: ghcr.io | |||
FULL_REF: ${{ inputs.tag && format('refs/tags/{0}', inputs.tag) || github.ref }} | |||
# This must match the entry in rustup-toolchain.toml at the repository root | |||
RUSTUP_TOOLCHAIN: "1.81.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we could name this RUST_TOOLCHAIN
to be consistent with the filename?
Also, could we read the appropriate value from the rust-toolchain.toml
file here rather than having to keep these in sync?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RUSTUP_TOOLCHAIN
is the actual env var that's read by rust: https://rust-lang.github.io/rustup/overrides.html#the-toolchain-file, so I'd like to keep that.
And I guess we could extract this, but I didn't want to move away from dtolnay/rust-toolchain (at least for now), and parsing toml files in workflows can only be done through obscure github actions, which I didn't feel comfortable introducing.
Followup?
Summary
Updates the rust toolchain used for all rust releated github jobs to and the containerfile to 1.81.0.
Background
Rust 1.81 was released and comes with a load of niceties that we would like to use. Among them of immediate interest are:
clippy::blocks_in_conditions
lint triggering on proc macros liketracing::instrument
(which chore(sequencer): Add instrumentation #1368 needed to work around)Note that this is orthgonal to setting the MSRV in individual Astria crates.
Changes
1.81.0
toolchain (except for rustfmt and dylint, which need nightlies, respectively).rust:1.81-bookwarm
as the base imageRelated Issues
Closes #1522