add bridge address and asset IDs to genesis and check during execution #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joroshiba
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
LGTM.
Should we make the config here a map though? Where each bridge address may support a different asset id, this would support a situation where you could bridge an ERC20 or something via a different bridge.
This could be something we add at a later date though.
|
right now we don't support ERC20s, any deposit corresponds to native tokens directly minted. so should leave as-is for now, we can update it later when we have ERC20 support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
astriaBridgeAddressesshould be a list of sequencer addresses (hex encoded with 0x prefix).astriaBridgeAllowedAssetDenomshould be the denom (not ID) of the asset allowed to be bridged over (as this will become the minted native token, there can only be one asset). examples:nria,channel-0/transfer/tiadeposits that do not have the right bridge address or asset denom are ignored.