Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests #1

Conversation

atugushev
Copy link

@atugushev atugushev commented Mar 1, 2021

  • Fixed failing test_command_line_setuptools_nested_output_file -- pip-compile setup.py requires the network to install setuptools and wheel during build time.
  • Revisited and simplified test_command_line_setuptools_read and test_command_line_setuptools_output_file tests
  • Added a test that pip-compile setup.py preserves environment markers

Addresses jazzband#1311 (comment)

@astrojuanlu
Copy link
Owner

Awesome, thanks a lot and sorry for the delay!

@astrojuanlu astrojuanlu merged this pull request into astrojuanlu:use-pep517-load-metadata Mar 1, 2021
@atugushev atugushev deleted the pr-1311-suggestions branch March 1, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants