Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin pytest<6 #453

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Pin pytest<6 #453

merged 1 commit into from
Jul 29, 2020

Conversation

pllim
Copy link
Member

@pllim pllim commented Jul 28, 2020

Need to pin pytest<6 until a new pytest-doctestplus with fix for scientific-python/pytest-doctestplus#118 is released. The patch is modeled after what @bsipocz did in #445 but in reverse (if that makes sense...).

cc @astrofrog

@pllim
Copy link
Member Author

pllim commented Jul 28, 2020

Do we still support Appveyor? Should I care that Appveyor failed?

@bsipocz
Copy link
Member

bsipocz commented Jul 28, 2020

If the appveyor failure is related, then yes it ideally should be fixed. If it's failing with something unrelated maybe the plug can be pulled in the near future (I'm reluctant to do it as quite a lot of projects used to use ci-helpers outside of astropy, so while this is a bit of a blast from the past at this point, as we see close to home, projects' leaderships may care little to nothing about DevOps leaving projects stuck with obsolete solutions).

@pllim
Copy link
Member Author

pllim commented Jul 29, 2020

Re: Appveyor failures

conda doesn't support Python 2.7 and 3.5 anymore, so those can probably be dropped from the matrix. The rest of the jobs are failing because conda is too old. So, I don't think they are related and I have no desire to fix them.

UnsatisfiableError: The following specifications were found
to be incompatible with the existing python installation in your environment:
Specifications:
  - conda=4.7 -> python[version='>=2.7,<2.8.0a0|>=3.7,<3.8.0a0|>=3.6,<3.7.0a0']
Your python: python=3.8
If python is on the left-most side of the chain, that's the version you've asked for.

@bsipocz
Copy link
Member

bsipocz commented Jul 29, 2020

OK, let's see what a rebuild of the last merge says. 20 days days ago it was still all green. If the rerun lights up the same as this PR, I'm pushing the merge button.

@pllim
Copy link
Member Author

pllim commented Jul 29, 2020

Sounds like a plan. Thanks, @bsipocz !

@bsipocz bsipocz merged commit e135ca1 into astropy:master Jul 29, 2020
@bsipocz
Copy link
Member

bsipocz commented Jul 29, 2020

OK, so appveyor is very badly broken already. Something for another day....

@pllim pllim deleted the pin-pytest-lt-6 branch July 29, 2020 15:56
@pllim
Copy link
Member Author

pllim commented Jul 29, 2020

Thanks for checking and the merge!

@pllim pllim mentioned this pull request Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants