Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parallel mode broken in Linux #44

Closed
loganmc10 opened this issue Nov 21, 2017 · 12 comments
Closed

parallel mode broken in Linux #44

loganmc10 opened this issue Nov 21, 2017 · 12 comments
Labels

Comments

@loganmc10
Copy link

In Windows, selecting the "Parallel" option works (mupen64plus). In Linux, the application freezes and must be force closed.

@ata4 ata4 added the bug label Nov 29, 2017
@ata4
Copy link
Owner

ata4 commented Nov 29, 2017

Hm, that one might be difficult to debug for me... I'll see what I can do about it.

@loganmc10
Copy link
Author

I got around to bisecting this, it looks like the bad commit is eef6466 (but actually I tested 5cbd52e, since it's needed to compile, but I assume the problem is in eef6466 )

I had to remove the "build" folder in between testing commits or else my bisecting would get messed up (it would work when it shouldn't etc...)

Anyway so basically d1cb99f is the last commit that worked for me

@Jj0YzL5nvJ
Copy link

In my case the application freezes is random in the start, I can't reproduce it with 100% certain.
But I've noticed that it's easier to get all working when firefox is closed.

@ata4
Copy link
Owner

ata4 commented Dec 24, 2017

As far as I can tell, the renderer itself is fine, since the retracer runs stable and fast with parallel rendering enabled on my Ubuntu VM. I'll need to check the M64P plugin interface next.

@ata4
Copy link
Owner

ata4 commented Dec 25, 2017

Oh, never mind my previous reply, I forgot to run the retracer with the -p flag. It was actually a deadlock issue during the initialization in parallel.cpp, because the constructor didn't wait for the threads to reach a mutex before running tasks. It should be fixed now.

@ata4 ata4 closed this as completed in d52d94f Dec 25, 2017
@Jj0YzL5nvJ
Copy link

I can still reproduce this problem, 1/30 attempts. Is very random.

@ata4 ata4 reopened this Jan 15, 2018
@ata4
Copy link
Owner

ata4 commented Jan 15, 2018

Haven't been able to reproduce so far. But I'll reopen it in case anyone else knows more.

@loganmc10
Copy link
Author

I haven't had any issues since you closed this

ata4 added a commit that referenced this issue Feb 19, 2018
Since m_task was initialized after threads are created, there's a small time window where workers could encounter an uninitialized m_task.

Possible complementary fix for #44
ata4 added a commit that referenced this issue Feb 19, 2018
This should fix several weird glitches, hangs and crashes introduced by d52d94f. May help #44 as well.
@ata4
Copy link
Owner

ata4 commented Feb 19, 2018

I have found two more (silly) mistakes that could have been responsible for the crashes and some abnormalities caused by d52d94f.

@loganmc10
Copy link
Author

Can this be closed then? Seems stable to me

@ata4
Copy link
Owner

ata4 commented Feb 22, 2018

Yeah, I hope it is now.

@ata4 ata4 closed this as completed Feb 22, 2018
@Jj0YzL5nvJ
Copy link

Finally, I can no longer reproduce this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants