Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Hacking on Atom Core: Update build requirements to be accurate #630

Merged
merged 11 commits into from
Oct 5, 2020

Commits on Jul 3, 2020

  1. Hacking on Atom Core: Update Python, VS info

    Information on required Visual Studio versions and Python versions
    were out of date, considering that we use newer `node-gyp` now.
    DeeDeeG committed Jul 3, 2020
    Configuration menu
    Copy the full SHA
    d378e0e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3932f5a View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2020

  1. hacking-on-atom-core.md: No Python3 on Windows

    Python 3 will be supported on Windows when atom/atom#20856
    or similar gets merged into the atom repository.
    DeeDeeG committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    d35008d View commit details
    Browse the repository at this point in the history
  2. hacking-on-atom-core.md: windows-build-tools is great

    This should be a recommended way of getting build tools set up.
    It works really well, and is much easier than
    a manual install of Visual Studio/C++ tools/Python 2.
    
    It sets them all up for you. I personally wouldn't
    recommend any other way to someone I knew.
    
    Co-authored-by: Amin Yahyaabadi <aminyahyaabadi74@gmail.com>
    DeeDeeG and aminya committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    1ba2105 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2020

  1. hacking-on-atom-core.md: Update windows info

    Visual Studio 2015, 2017 and 2019 are supported.
    Windows 8 SDK or Windows 10 SDK are supported.
    Clarified windows-build-tools install instructions.
    The latest windows-build-tools will be fine for the foreseeable future
    (Even when they default to Visual Studio 2019 some time soon.)
    DeeDeeG committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    88cf835 View commit details
    Browse the repository at this point in the history
  2. hacking-on-atom-core.md: Python 2.6, 2.7 and 3.5+

    Update install instructions for Windows.
    DeeDeeG committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    7dcf363 View commit details
    Browse the repository at this point in the history
  3. hacking-on-atom-core.md: 7-Zip install not needed

    This is now a dependency "7zip-bin" in `scripts/package.json`.
    
    The script doesn't look for 7-Zip on the system anymore,
    so it wouldn't be used even if installed.
    DeeDeeG committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    c55744a View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2020

  1. hacking-on-atom-core: Suggest windows-build-tools

    This should be the first option. It is recommended by node-gyp and Microsoft.
    
    It is either officially or unofficially developed and maintained by Microsoft themselves.
    DeeDeeG committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    53ec234 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2020

  1. atom-core: Tweak windows-build-tools install

    - Suggest installing windows-build-tools v4,
    as v5 can hang and fail to install.
    
    - Don't use the `--production` flag to install
    windows-build-tools; Not installing devDependencies
    is already implied when installing a package by name.
    DeeDeeG committed Sep 28, 2020
    Configuration menu
    Copy the full SHA
    ae35fc0 View commit details
    Browse the repository at this point in the history
  2. hacking-on-atom-core: No Visual Studio 2019

    Building Atom with Visual Studio 2019 causes a few CI tests to fail,
    so hold off on recommending Visual Studio 2019 for now.
    DeeDeeG committed Sep 28, 2020
    Configuration menu
    Copy the full SHA
    b72c20a View commit details
    Browse the repository at this point in the history
  3. hacking-on-atom-core: Suggest npm 6.12 or later

    This version of npm includes newer node-gyp,
    which is better at automatically detecting Python
    (especially Python 3), and also better at 
    automatically detecting Visual Studio.
    DeeDeeG committed Sep 28, 2020
    Configuration menu
    Copy the full SHA
    50f9a18 View commit details
    Browse the repository at this point in the history