Fix use-render

atomicojs · Mar 9, 2024 · 19be0c1 · 19be0c1
1 parent 3bd17c9
commit 19be0c1
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 18 deletions.
diff --git a/packages/use-child-nodes/test/use-render.test.js b/packages/use-child-nodes/test/use-render.test.js
diff --git a/packages/use-render/example/index.tsx b/packages/use-render/example/index.tsx
@@ -4,6 +4,9 @@ import { useRender } from "../src";
 const MyComponent = c(
 	({ name, checked }) => {
 		useRender(<input type="checkbox" name={name} checked={checked} />);
+		useRender(() => (
+			<input type="checkbox" name={name} checked={checked} />
+		));
 
 		return (
 			<host shadowDom>

diff --git a/packages/use-render/src/index.tsx b/packages/use-render/src/index.tsx
@@ -10,12 +10,16 @@ const fillHost = (vnode?: any) =>
  * Generate a second render, this render escapes the current
  * one and is useful for collaborative work between LightDOM and shadowDOM
  */
-export function useRender(callback: () => any, args?: any[]) {
+export function useRender(view: any, args?: any[]) {
 	const host = useHost();
 
 	host.id = host.id || Symbol();
 
 	useInsertionEffect(() => {
-		render(fillHost(callback), host.current, host.id);
+		render(
+			fillHost(typeof view === "function" ? view() : view),
+			host.current,
+			host.id,
+		);
 	}, args);
 }
diff --git a/packages/use-render/test/example.tsx b/packages/use-render/test/example.tsx
diff --git a/packages/use-render/test/use-render.test.js b/packages/use-render/test/use-render.test.js
@@ -11,5 +11,7 @@ it("use-render", () => {
 		useRender(() => html`<button />`);
 	});
 
+	hooks.cleanEffects()()();
+
 	expect(container.querySelector("button")).to.not.equal(null);
 });