Support point clouds #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
closing in favor of #3 |
atteneder
added a commit
that referenced
this pull request
Nov 6, 2023
* chore: Fixed CI runner image to avoid future surprises * ci: Refactored/simplified Unity build script * ci: Disabled Emscripten builds, as those moved into other CI jobs * ci: Fixed deprecated parameter * fix: Adressed linker errors due to duplicated symbols in `draco` and `dracodec_unity`. - Consolidated dracodec_unity and dracoenc_unity into a single target named draco_unity * chore: Renamed iOS simulator library name to avoid name conflict with device SDK variant. * fix: Attempt to create universal binary * fix: Attempt to create universal binary by providing architectures * feat: Apple tvOS and Apple visionOS support * chore: Raised iOS/tvOS target to 11.0, since this is the minimum version for Unity 2020 LTS * feat: Added Windows ARM64 support * fix: visionOS required dynamic libraries * Revert "chore: Raised iOS/tvOS target to 11.0, since this is the minimum version for Unity 2020 LTS" It broke the build This reverts commit 1eb874b. --------- Co-authored-by: Andreas Atteneder <andreas.atteneder@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds point cloud support to the DracoUnity API.
There is a minor increase in binary size (~30kb to the windows x64 dll if I recall correctly).
I've attempted to change as little as possible in how the project functions - predominantly just adding the
DracoMesh.is_point_cloudboolean.See atteneder/DracoUnity#28 for the DracoUnity component.