refactor: Reduce OTel dependencies (open-feature#132)

Signed-off-by: Austin Drenski <austin@austindrenski.io> Co-authored-by: Todd Baert <todd.baert@dynatrace.com>
austindrenski · Jan 11, 2024 · de86b0e · de86b0e
1 parent d3aea9e
commit de86b0e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 17 deletions.
diff --git a/src/OpenFeature.Contrib.Hooks.Otel/OpenFeature.Contrib.Hooks.Otel.csproj b/src/OpenFeature.Contrib.Hooks.Otel/OpenFeature.Contrib.Hooks.Otel.csproj
@@ -13,8 +13,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="OpenTelemetry" Version="1.4.0" />
-    <PackageReference Include="OpenTelemetry.Exporter.Console" Version="1.4.0" />
+    <PackageReference Include="OpenTelemetry.Api" Version="1.4.0" />
   </ItemGroup>
 
 </Project>
diff --git a/src/OpenFeature.Contrib.Hooks.Otel/TracingHook.cs b/src/OpenFeature.Contrib.Hooks.Otel/TracingHook.cs
@@ -1,6 +1,7 @@
 using OpenFeature.Model;
 using System.Threading.Tasks;
 using System.Collections.Generic;
+using System.Diagnostics;
 using OpenTelemetry.Trace;
 
 namespace OpenFeature.Contrib.Hooks.Otel
@@ -22,17 +23,16 @@ public class TracingHook : Hook
         public override Task After<T>(HookContext<T> context, FlagEvaluationDetails<T> details,
             IReadOnlyDictionary<string, object> hints = null)
         {
-            var span = Tracer.CurrentSpan;
-            if (span != null)
-            {
-                var attributes = new Dictionary<string, object>
+            Activity.Current?
+                .SetTag("feature_flag.key", details.FlagKey)
+                .SetTag("feature_flag.variant", details.Variant)
+                .SetTag("feature_flag.provider_name", context.ProviderMetadata.Name)
+                .AddEvent(new ActivityEvent("feature_flag", tags: new ActivityTagsCollection
                 {
-                    {"feature_flag.key", details.FlagKey},
-                    {"feature_flag.variant", details.Variant},
-                    {"feature_flag.provider_name", context.ProviderMetadata.Name}
-                };
-                span.AddEvent("feature_flag", new SpanAttributes(attributes));
-            }
+                    ["feature_flag.key"] = details.FlagKey,
+                    ["feature_flag.variant"] = details.Variant,
+                    ["feature_flag.provider_name"] = context.ProviderMetadata.Name
+                }));
 
             return Task.CompletedTask;
         }
@@ -47,11 +47,7 @@ public override Task After<T>(HookContext<T> context, FlagEvaluationDetails<T> d
         public override Task Error<T>(HookContext<T> context, System.Exception error,
             IReadOnlyDictionary<string, object> hints = null)
         {
-            var span = Tracer.CurrentSpan;
-            if (span != null)
-            {
-                span.RecordException(error);
-            }
+            Activity.Current?.RecordException(error);
 
             return Task.CompletedTask;
         }