Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IAMRISK-2817] Update API for Arkose to use a callback based API #1349

Merged
merged 11 commits into from
Oct 19, 2023
Merged

[IAMRISK-2817] Update API for Arkose to use a callback based API #1349

merged 11 commits into from
Oct 19, 2023

Commits on Oct 17, 2023

  1. Update API for Arkose to use a Promise

    @srijonsaha
    srijonsaha committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    37f0d87 View commit details
    Browse the repository at this point in the history

  2. Use callback and add unit tests

    @srijonsaha
    srijonsaha committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    eb3264e View commit details
    Browse the repository at this point in the history

  3. Remove async

    @srijonsaha
    srijonsaha committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    249601d View commit details
    Browse the repository at this point in the history

  4. Remove onError and onSolved callbacks

    @srijonsaha
    srijonsaha committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    29bf3ee View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Address feedback

    @srijonsaha
    srijonsaha committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    3f04f94 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. Use callback based API

    @srijonsaha
    srijonsaha committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    9a91a15 View commit details
    Browse the repository at this point in the history

  2. Fix lint issues

    @srijonsaha
    srijonsaha committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    34632d2 View commit details
    Browse the repository at this point in the history

  3. Fix tests

    @srijonsaha
    srijonsaha committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    38ee8f0 View commit details
    Browse the repository at this point in the history

  4. Fix typos

    @srijonsaha
    srijonsaha committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    b6c5986 View commit details
    Browse the repository at this point in the history

  5. Improve JS Doc

    @srijonsaha
    srijonsaha committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    932612f View commit details
    Browse the repository at this point in the history

  6. Update JS Doc

    @srijonsaha
    srijonsaha committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    706a32a View commit details
    Browse the repository at this point in the history