Add MMR data verification. #3037
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamil-gadelshin
requested review from
NingLin-P,
nazar-pc and
rg3l3dr
as code owners
teor2345
reviewed
Sep 20, 2024
teor2345
reviewed
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds verification to the MMR data acquired during the domain snap sync. The idea is to collect the received data in a similar structure
MMRas the actual pallet does and compare calculated root with the MMR root from the downloaded state using the runtime API call. The block number for the runtime API call is the target block number for the state download.The code worked in the local tests when all domain snap-sync components are enabled.
Code contributor checklist: