Update libp2p to 0.54.1, remove unnecessary method call #3046
+16
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
requested changes
Sep 22, 2024
| @@ -24,15 +23,11 @@ pub(super) fn build_transport( | |||
| timeout: Duration, | |||
| yamux_config: YamuxConfig, | |||
| ) -> io::Result<Boxed<(PeerId, StreamMuxerBox)>> { | |||
| let wrapped_tcp = { | |||
| let tcp_config = GenTcpConfig::default().nodelay(true); | |||
There was a problem hiding this comment.
it seems like this is still required, because the merged PR got the setting the wrong way around, and used Some(false):
https://github.com/libp2p/rust-libp2p/pull/5469/files#r1758528479
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TCP_NODELAYis disabled by default sincelibp2p-tcp0.41.1, while we already used0.42.0. Also there was some unnecessary cloning present that clippy didn't catch for some reason.Code contributor checklist: