-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docker): avoid empty string in bake's arguments when targets
not specified
#3303
fix(docker): avoid empty string in bake's arguments when targets
not specified
#3303
Conversation
13d5110
to
99a61b9
Compare
…ets` not specied Signed-off-by: maleicacid <kazukuro0824+dev@gmail.com>
99a61b9
to
3d87c7e
Compare
@kazuki0824 Thank you for your contribution! |
@kenji-miyake Can you review this? |
targets
not specified
…t specified Signed-off-by: maleicacid <kazukuro0824+dev@gmail.com>
I found another solution using array expansion: by making |
Without this PR, docker/build.sh will fail. Lines 38 to 44 in 3555383
and then an empty string will be added to the bottom of the argv of the bake :Lines 66 to 76 in 3555383
|
targets
not specifiedtargets
not specified
Description
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.