Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ansible): disable artifact download prompt in with -y flag #4026

Conversation

lexavtanke
Copy link
Contributor

@lexavtanke lexavtanke commented Nov 29, 2023

Description

Fix #4006.
Also new --download-artifacts option was introduced. User can configure if he want to download artifacts or no then starting the script.

Tests performed

With ./setup-dev-env.sh -y no prompts are produced.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@lexavtanke lexavtanke force-pushed the 4006-disable-artifacts-promt-in-silent-mode branch from 2ce2638 to 9ccccec Compare November 29, 2023 16:31
@lexavtanke lexavtanke marked this pull request as ready for review November 29, 2023 16:32
Copy link
Contributor

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lexavtanke LGTM, thanks!

@esteve esteve merged commit 894fd0b into autowarefoundation:main Nov 29, 2023
15 checks passed
oguzkaganozt pushed a commit that referenced this pull request Feb 19, 2024
* fix(ansible): disable artifact download prompt in with -y flag

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>

* style(pre-commit): autofix

---------

Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prompt is shown even if -y flag is used when running setup-dev-env.sh
2 participants