Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware): increase initialize duration #4053

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

brkay54
Copy link
Member

@brkay54 brkay54 commented Dec 11, 2023

Description

In the AWF project on Autoware Evaluator, scenarios on the large maps are failing during initialization. As you can see in the latest test of the catalog, the number of the SimulationError:AutowareError is very high. The errors occur mostly because of Simulation error [AutowareError]: Simulator waited for the Autoware state to transition to WaitingForEngage, but time is up. .

These AutowareError labeled failings occur for scenarios in a specific map that is larger than others and some of them are tested locally and they work successfully.

In today's ODD WG meeting, we think increasing the initialize_duration parameter may solve the high number of AutowareError labeled failings.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Berkay Karaman <brkay54@gmail.com>
Copy link

@Igata-ctrl Igata-ctrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brkay54
Copy link
Member Author

brkay54 commented Dec 14, 2023

Hi @mitsudome-r @Igata-ctrl, I can not merge the PR because of Only those with [write access](https://docs.github.com/articles/what-are-the-different-access-permissions) to this repository can merge pull requests.. If you have write access, could you merge it?

@mitsudome-r mitsudome-r merged commit aab95eb into autowarefoundation:main Dec 15, 2023
16 checks passed
@brkay54 brkay54 deleted the odd/init-time branch December 15, 2023 08:13
oguzkaganozt pushed a commit that referenced this pull request Feb 19, 2024
Signed-off-by: Berkay Karaman <brkay54@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants