Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(artifacts): update traffic_light_fine_detector and traffic_light_classifier artifacts #4087

Merged
merged 4 commits into from
Dec 28, 2023

Conversation

yukke42
Copy link
Contributor

@yukke42 yukke42 commented Dec 26, 2023

Description

depends on autowarefoundation/autoware.universe#5871

  • to update onnx models and text labels

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yukke42 <yukke42@users.noreply.github.com>
@yukke42 yukke42 marked this pull request as draft December 26, 2023 02:10
Signed-off-by: yukke42 <yukke42@users.noreply.github.com>
@yukke42 yukke42 marked this pull request as ready for review December 26, 2023 02:46
Copy link

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yukke42
We need to update instructions in README.md as well

Copy link
Contributor

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yukke42 thanks!

Signed-off-by: yukke42 <yukke42@users.noreply.github.com>
Signed-off-by: yukke42 <yukke42@users.noreply.github.com>
@yukke42
Copy link
Contributor Author

yukke42 commented Dec 28, 2023

@miursh I have updated yolox-s links and readme.

Copy link

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@mitsudome-r mitsudome-r merged commit bf95c38 into autowarefoundation:main Dec 28, 2023
15 checks passed
@yukke42 yukke42 deleted the update-tlr-artifacts branch December 28, 2023 06:59
mitsudome-r pushed a commit that referenced this pull request Jan 31, 2024
…_classifier artifacts (#4087)

* feat: add traffic_light_classifier artifacts

Signed-off-by: yukke42 <yukke42@users.noreply.github.com>

* feat: update traffic_light_fine_detector artifacts

Signed-off-by: yukke42 <yukke42@users.noreply.github.com>

* chore: rename tlr yolox-s onnx files

Signed-off-by: yukke42 <yukke42@users.noreply.github.com>

* docs: update instruction

Signed-off-by: yukke42 <yukke42@users.noreply.github.com>

---------

Signed-off-by: yukke42 <yukke42@users.noreply.github.com>
oguzkaganozt pushed a commit that referenced this pull request Feb 19, 2024
…_classifier artifacts (#4087)

* feat: add traffic_light_classifier artifacts

Signed-off-by: yukke42 <yukke42@users.noreply.github.com>

* feat: update traffic_light_fine_detector artifacts

Signed-off-by: yukke42 <yukke42@users.noreply.github.com>

* chore: rename tlr yolox-s onnx files

Signed-off-by: yukke42 <yukke42@users.noreply.github.com>

* docs: update instruction

Signed-off-by: yukke42 <yukke42@users.noreply.github.com>

---------

Signed-off-by: yukke42 <yukke42@users.noreply.github.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants