Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lidar_centerpoint_tvm): remove artifacts #4919

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jun 26, 2024

Description

See autowarefoundation/autoware.universe#7702

Tests performed

See autowarefoundation/autoware.universe#7702

Effects on system behavior

See autowarefoundation/autoware.universe#7702

Interface changes

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda marked this pull request as draft June 26, 2024 05:11
@kminoda kminoda marked this pull request as ready for review June 27, 2024 13:07
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
The PR title would be remove artifacts instead.

@kminoda
Copy link
Contributor Author

kminoda commented Jul 2, 2024

Thank you for the review!
@xmfcx @mitsudome-r Would you merge this PR?

@xmfcx xmfcx changed the title feat(lidar_centerpoint_tvm): remove package feat(lidar_centerpoint_tvm): remove artifacts Jul 2, 2024
@xmfcx xmfcx merged commit 36a88ee into autowarefoundation:main Jul 2, 2024
13 of 14 checks passed
pravinkmr26 pushed a commit to pravinkmr26/autoware that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants