Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump up autoware_lanelet2_extension #5134

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Aug 28, 2024

Description

autowarefoundation/autoware_lanelet2_extension#26

Related links

Tests performed

see autowarefoundation/autoware_lanelet2_extension#26

Notes for reviewers

Interface changes

see autowarefoundation/autoware_lanelet2_extension#26 for more detail

ROS Topic Changes

ROS Parameter Changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@mitsudome-r mitsudome-r changed the title bump up autoware_lanelet2_extension chore: bump up autoware_lanelet2_extension Aug 28, 2024
@mitsudome-r mitsudome-r added the tag:run-health-check Run health-check label Aug 28, 2024
Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code modification looks good to me.
I triggered health-check workflow just in case.
https://github.com/autowarefoundation/autoware/actions/runs/10592349291/job/29351504033?pr=5134

We can merge it once it passes.

@mitsudome-r mitsudome-r merged commit a97afaf into autowarefoundation:main Aug 28, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-health-check Run health-check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants