Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): introduce autoware-universe-common stage #5157

Merged
merged 12 commits into from
Sep 3, 2024

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Sep 2, 2024

Description

To proceed with the multi-containerization of Autoware, This PR first added the autoware-universe-common stage as a common layer for autoware-universe. However, there are issues with the packages under the common directory of autoware.universe, and TODO comments have been left.

In the next PR, we plan to create a PR that splits autoware-universe into multiple container images.

Ref: https://github.com/orgs/autowarefoundation/discussions/4661#discussioncomment-9995806
346866514-690b88ac-ee85-490a-93d8-14f8626c3e2e

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@youtalk youtalk added type:containers Docker containers, containerization of components, or container orchestration. component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check labels Sep 2, 2024
@youtalk youtalk self-assigned this Sep 2, 2024
@youtalk youtalk marked this pull request as ready for review September 2, 2024 07:07
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youtalk youtalk merged commit 28deda8 into main Sep 3, 2024
15 checks passed
@youtalk youtalk deleted the upstream-autoware-universe-common-stage branch September 3, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check type:containers Docker containers, containerization of components, or container orchestration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants