-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docker): rename multi-stages #5170
Conversation
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@youtalk -san, could you also update the https://github.com/autowarefoundation/autoware/tree/main/docker#readme too when making these changes? Referred in issue: |
@youtalk -san, I think the latest keyword is also becoming redundant, what do you think of removing it?
Referred in issue: |
If we remove the |
If it has timestamp, it can have the timestamp in the tag. If it doesn't have a timestamp (it is latest) it will be without latest keyword. |
Whenever user pulls an image, say On the other hand |
Description
As mentioned in this opinion #5164 (review) by @oguzkaganozt, the
Dockerfile
is becoming increasingly complex for the following reasons:Therefore, this PR introduces the following naming conventions to make it easier to maintain a one-to-one correspondence between development and runtime containers, even as multi-container setups become more prevalent:
-devel
are development containers, while those without the suffix are runtime containers.autoware-
is no longer used.The generated images will have names like the following.
autoware:latest-base
autoware:latest-base
autoware:latest-autoware-core
autoware:latest-core-devel
autoware:latest-autoware-universe
autoware:latest-universe-devel
autoware:latest-devel
autoware:latest-devel
autoware:latest-runtime
autoware:latest-universe
Before:
After:
Tests performed
youtalk#102
https://github.com/youtalk/autoware/actions/runs/10712585980
Effects on system behavior
Documentation, shell scripts, and the GitHub Actions settings in the
autoware.universe
repository also need to be updated.Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.