Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): add vehicle-system container #5257

Merged
merged 7 commits into from
Sep 27, 2024

Conversation

oguzkaganozt
Copy link
Contributor

@oguzkaganozt oguzkaganozt commented Sep 19, 2024

Description

Add vehicle-system module container according to the proposal

Tests performed

https://github.com/autowarefoundation/autoware/actions/runs/10962267642

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@oguzkaganozt oguzkaganozt self-assigned this Sep 19, 2024
@oguzkaganozt oguzkaganozt added type:containers Docker containers, containerization of components, or container orchestration. component:openadkit Issues or Features related to Open AD Kit labels Sep 19, 2024
@oguzkaganozt
Copy link
Contributor Author

@youtalk please review

Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't determine the optimal granularity for separating the other universe containers.
@mitsudome-r @xmfcx What do you think?

@oguzkaganozt
Copy link
Contributor Author

@youtalk @mitsudome-r @xmfcx IMHO, in order to make it possible to develop/deploy autoware within a fully modularized environment we should have containers for each autoware/universe directory that being:

  • planning universe-planning-control
  • control universe-planning-control
  • sensing universe-sensing-perception
  • perception universe-sensing-perception
  • map universe-localization-mapping
  • localization universe-localization-mapping
  • vehicle universe-vehicle-system
  • system universe-vehicle-system

And optional containers for:

  • simulator universe-simulator-evaluator
  • evaluator universe-simulator-evaluator

@oguzkaganozt
Copy link
Contributor Author

oguzkaganozt commented Sep 20, 2024

@youtalk Updated and started a new workflow run https://github.com/autowarefoundation/autoware/actions/runs/10962267642 for generating images

@oguzkaganozt oguzkaganozt force-pushed the add-vehicle-system-container branch 2 times, most recently from 71a0803 to b17fbd2 Compare September 24, 2024 09:59
@mitsudome-r
Copy link
Member

I think it's reasonable to have vehicle as a separate container. (This module could be modified/replaced by the users depending on their vehicle hardware)

Regarding the system component, we might need to have some discussions. It might be suitable to be merged with planning/control as we don't have a completely fixed interface defined between the system component and the rest of Autoware.

Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the Dockerfile.svg by using https://github.com/patrickhoefler/dockerfilegraph.

oguzkaganozt and others added 7 commits September 27, 2024 11:58
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
@oguzkaganozt oguzkaganozt enabled auto-merge (squash) September 27, 2024 09:01
@oguzkaganozt oguzkaganozt merged commit f24de1e into main Sep 27, 2024
15 checks passed
@oguzkaganozt oguzkaganozt deleted the add-vehicle-system-container branch September 27, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check type:containers Docker containers, containerization of components, or container orchestration.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants