Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: temporary fix for turbo bug with lazy loading #3160

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

Paul-Bob
Copy link
Contributor

Description

Temporarily fixes #2607

I subscribed to the PR that natively fixes the turbo issue. We should revert this temporary fix after the PR gets merged.

This solution appears to fix the problem and was suggested several times on the original issue.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob added the Fix label Aug 21, 2024
@Paul-Bob Paul-Bob self-assigned this Aug 21, 2024
Copy link

codeclimate bot commented Aug 21, 2024

Code Climate has analyzed commit 04bbc47 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Collaborator

@adrianthedev adrianthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship it!

@adrianthedev
Copy link
Collaborator

So awesome that you found it!

@Paul-Bob
Copy link
Contributor Author

So awesome that you found it!

Pair debug session for the win!

@Paul-Bob Paul-Bob merged commit e352dee into main Aug 21, 2024
23 checks passed
@Paul-Bob Paul-Bob deleted the fix/turbo_requests_after_browser_back branch August 21, 2024 10:13
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants