Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the base value when using iec standard #153

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Fixing the base value when using iec standard #153

merged 1 commit into from
Jun 16, 2022

Conversation

avoidwork
Copy link
Owner

@avoidwork avoidwork commented Jun 16, 2022

PS C:\Users\jason\Projects\filesize.js\lib> node            
Welcome to Node.js v18.2.0.
Type ".help" for more information.
> const filesize = require('./filesize.es6.js')
undefined
> console.log(filesize(265318, {standard: "jedec"}), filesize(265318, {standard: "iec"}))
259.1 KB 265.32 KiB
undefined

@avoidwork avoidwork self-assigned this Jun 16, 2022
@avoidwork
Copy link
Owner Author

This PR wasn't published - version burned; assignment happened after a ternary that uses base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standard property does not switch base
1 participant