Skip to content

Commit

Permalink
[Obs UX] Flaky test retry fix (elastic#169918)
Browse files Browse the repository at this point in the history
Closes elastic#169081 
## Summary

From the [build
screenshot](https://buildkiteartifacts.com/e0f3970e-3a75-4621-919f-e6c773e2bb12/b1106efc-ba5e-4e90-a857-11c4a899c05d/018b6531-12aa-4b1f-ae08-fe0268c66355/018b6532-e60c-4d10-871b-f2840d57b7ea/target/test_failures/018b6532-e60c-4d10-871b-f2840d57b7ea_5295cb1f7df0a4e3892a49e325077ec4.html?response-content-type=text%2Fhtml&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=ASIAQPCP3C7LSNRXAZM5%2F20231026%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20231026T100921Z&X-Amz-Expires=600&X-Amz-Security-Token=IQoJb3JpZ2luX2VjEEYaCXVzLWVhc3QtMSJGMEQCIGhXJS1VvkibyMLJ%2FA%2Fsl0q5DYSyfpCYUQ7oitA1SbHjAiBeGs4DWHVEpNE9X6FKD4%2FTM5CnARkC0AJ7jMnh6DrKjyrxAwhuEAAaDDAzMjM3OTcwNTMwMyIMXItogE7G9vjHZKr%2BKs4D3%2FUVEDd9v0cDIHon57SzWrKDM5c9RChzQPW%2BYmi293Rg35M%2BSYPbhyX4bRqF7D8AvRz7zSsNTHJXGpYRsiLkgbnSP5jourtQmYatmu6KKDH96zR9jdtGqwGkbIcsmql5wV8czeFrmNzCn0zGGb3XTKBTTKJDHDN7eu%2Fvt2xJ%2BYLif6up21PF6zIGKDohRZLiPB6%2FvXqWfy%2F3Z4RK8JhJGQE8RhrLopLxLllBt2j15SvEFiI6J2GeSDJdS3%2F7v45auGTvsKCVkAKlBv3iW2XezyDxnVNkFetBefz00lLLZ2OX3MOln7q7%2Fc7BEiJa%2BegGID7VyvIsXVxuaNfg5zB3bP%2F8p2bxPoATAJqhBHpqhdMJiVa0w6VbAkzMELIwEHjXDqvIS2%2BekDvm8WgXwNCCzr4qizGfNRtLPje5B6IaCr%2FND2jNVHXrop20bzxnHAreci2%2BOlxz%2FaPJUBWvehvD0B0dy9q8zIsjgiyx%2BslJgfXYeP7YNcQ769SAKuTn1hP2OIj1U8fcsfnuagY792PVuVxs1hFDQ9IzPRkZ5fU98rOuHO82x9GfWuzzkv50vIk%2BlvPvlXev6Ez9ZqQ8aXoC3KKgyHRYmBjpGFEt8szkMNjs56kGOqYBBiihNfWTeetTlFhU8YTSrupG3wqyDkD0n%2BGzgM1v4LEHARj%2FUnlRctNMYaoQC5ou6tFMQDR5bmMKzt6JX4PWHmM%2FVxCgCrdfkXjPaBscR8zDkM%2Bls1B80gEGfGBQsBruNHGODcM9%2BYN%2Bu9%2BX%2BUUx50XBCzuYCr0UkrQtnE5g2dDDOrBtE2ElYokriPhngDNCmMihalGXu539X4Vr9I8U1RyQb%2Beq4g%3D%3D&X-Amz-SignedHeaders=host&X-Amz-Signature=6def38b8a92b24c41f503ff0647af3a4e317d833acb9b3b96777eb61d68f559e)
it's visible that the navigation is correct so we probably checked the
url before the page loaded so I added a retry and page load check

[Flaky tests runner
build](https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3757)
  • Loading branch information
jennypavlova authored and awahab07 committed Oct 31, 2023
1 parent ca0d731 commit 7a198a9
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions x-pack/test/functional/apps/infra/home_page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -199,16 +199,18 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
before(async () => {
await pageObjects.infraHome.clickOnNode();
await pageObjects.assetDetails.clickApmTabLink();
await pageObjects.infraHome.waitForLoading();
});

it('should navigate to APM traces', async () => {
const url = parse(await browser.getCurrentUrl());
const query = decodeURIComponent(url.query ?? '');
const kuery = 'kuery=host.hostname:"demo-stack-nginx-01"';

expect(url.pathname).to.eql('/app/apm/traces');
expect(query).to.contain(kuery);

await retry.try(async () => {
expect(url.pathname).to.eql('/app/apm/traces');
expect(query).to.contain(kuery);
});
await returnTo(INVENTORY_PATH);
});
});
Expand Down

0 comments on commit 7a198a9

Please sign in to comment.