fix: close file handle warning #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bombguy
requested review from
edwardfoyle,
sobolk,
Amplifiyer and
srquinn21
as code owners
🦋 Changeset detectedLatest commit: 76d171f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Amplifiyer
approved these changes
Nov 20, 2023
rtpascual
previously approved these changes
Nov 20, 2023
Amplifiyer
requested changes
Nov 20, 2023
packages/platform-core/src/config/local_configuration_controller.ts
Outdated
Show resolved
Hide resolved
Amplifiyer
previously approved these changes
Nov 20, 2023
rtpascual
previously approved these changes
Nov 20, 2023
Amplifiyer
approved these changes
Nov 20, 2023
rtpascual
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Closing file handle after reading config file.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.