fix: filter non-sandbox stacks #736
Conversation
johnpc
requested review from
edwardfoyle,
sobolk,
Amplifiyer and
srquinn21
as code owners
🦋 Changeset detectedLatest commit: 0a198ee The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/deployed-backend-client/src/deployed_backend_client.ts
Outdated
Show resolved
Hide resolved
| .map(async (stackSummary: StackSummary) => { | ||
| const deploymentType = await this.tryGetDeploymentType(stackSummary); | ||
|
|
There was a problem hiding this comment.
Do we now even need this call? Isn't it guaranteed that whatever got filtered is Sandbox deploymentType by definition?
There was a problem hiding this comment.
I think the idea is that it's possible for a stack to be named in way that matches the heuristic, but isn't truly a sandbox. The stack metadata is the best way to get the deploymentType.
| import { ArnGenerator } from './deployed-backend-client/arn_generator.js'; | ||
| import { ArnParser } from './deployed-backend-client/arn_parser.js'; | ||
|
|
||
| const listStacksMock = { |
There was a problem hiding this comment.
| const listStacksMock = { | |
| const listStacksMockResponse = { |
| ]; | ||
|
|
||
| beforeEach(() => { | ||
| getOutputMock.mock.mockImplementation( |
There was a problem hiding this comment.
These need not be in beforeEach I'm guessing, can be moved out to the describe
packages/deployed-backend-client/src/deployed_backend_client.ts
Outdated
Show resolved
Hide resolved
packages/deployed-backend-client/src/deployed_backend_client.ts
Outdated
Show resolved
Hide resolved
@sobolk We can make a change on the console side to incorporate more retries. |
johnpc
dismissed stale reviews from edwardfoyle, Amplifiyer, and sdstolworthy
via
0a198ee
johnpc
force-pushed
the
xss/filter-non-sandbox-stacks
branch
from
7f3ff40
to
0a198ee
Compare
johnpc
requested review from
sobolk,
edwardfoyle,
Amplifiyer and
sdstolworthy
Issue #, if available:
N/A
Description of changes:
There is currently an issue in deployed-backend-client where calling
getOutputfor every stack to determinedeploymentType: 'sandbox'is causing high latency and throttling exceptions fromlistSandboxes.This PR adds a heuristic to filter stacks that are not named using the sandbox naming convention in order to prevent excessive
getOutputcalls.I've also refactored the test suite a bit since it was getting unruly.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.