Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): HostedUI oidc signout #13512

Merged
merged 38 commits into from
Sep 3, 2024
Merged

feat(auth): HostedUI oidc signout #13512

merged 38 commits into from
Sep 3, 2024

Conversation

Samaritan1011001
Copy link
Contributor

Description of changes

Updates the signOut API to allow customers to provide which redirect url to use enabling sign out of users from both Cognito Hosted UI and the upstream OIDC provider.

Issue #, if available

Description of how you validated changes

Sample app with HostedUI setup with Auth0 as the OIDC provider.

  • sign in using signWithRedirect
  • sign out with preferredRedirectUrl as the Auth0's logout endpoint
  • call signInWithRedirect to see that the Auth0 login again requires to enter user credentials.

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

israx
israx reviewed Jun 20, 2024
View reviewed changes
Copy link
Member

@israx israx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Manoj. Left a couple of comments

packages/auth/__tests__/providers/cognito/utils/oauth/getRedirectUrl.native.test.ts Outdated Show resolved Hide resolved
packages/auth/__tests__/providers/cognito/utils/oauth/getRedirectUrl.native.test.ts Outdated Show resolved Hide resolved
packages/auth/src/providers/cognito/utils/oauth/getRedirectUrl.native.ts Outdated Show resolved Hide resolved
packages/auth/src/providers/cognito/utils/oauth/getRedirectUrl.native.ts Outdated Show resolved Hide resolved
packages/auth/src/types/inputs.ts Show resolved Hide resolved
packages/auth/src/providers/cognito/utils/oauth/getRedirectUrl.ts Outdated Show resolved Hide resolved
@Samaritan1011001 Samaritan1011001 marked this pull request as ready for review July 18, 2024 21:58
israx
israx reviewed Jul 22, 2024
View reviewed changes
package.json Show resolved Hide resolved
@Samaritan1011001 Samaritan1011001 force-pushed the fix/redirect-rn branch 2 times, most recently from 1207e4f to 2d0d7c9 Compare July 24, 2024 20:21
israx and others added 15 commits August 20, 2024 15:37
@israx
chore(auth): add oauth metadata into token orchestrator (#13712) (#13736
c45bdfd 
)

* chore: add oauth metadata into token orchestrator

* chore: add unit tests

* chore: address feedback
@Samaritan1011001
wip: hardcode signout uri for poc
40d0b21
@Samaritan1011001
chore: expose the prefferedRedirectSignOutUrl
a6c710c
@Samaritan1011001
chore: add prefered url change to native file
6207d8d
@Samaritan1011001
chore: correct param name
1f043fd
@Samaritan1011001
chore: update getRedirectUrl function to consider preferred url
49eec47
@Samaritan1011001
chore: add unit test for the feature
4c47c15
@Samaritan1011001
chore: update input type to use the accepted format
cbec22f
@Samaritan1011001
chore: review comments
932cfbb
@Samaritan1011001
fix: address npm audit issues
569da99
@Samaritan1011001
chore: update comments, bundle size and rn version
1d1167a
@Samaritan1011001
chore: update bundle size limit
328b2d2
@Samaritan1011001
chore: update bundle size limit
e08b285
@Samaritan1011001
chore: address coments and rename a param to getRedirecturl funciton
b0983f7
@Samaritan1011001
chore: make preid release ready
2aaabf1
@Samaritan1011001 Samaritan1011001 requested a review from a team as a code owner August 22, 2024 23:52
@Samaritan1011001 Samaritan1011001 changed the base branch from feat/hosted-ui-sign-out to main August 22, 2024 23:52
@Samaritan1011001 Samaritan1011001 dismissed israx’s stale review August 22, 2024 23:52

The base branch was changed.

HuiSF
HuiSF previously approved these changes Aug 30, 2024
View reviewed changes
israx
israx previously approved these changes Aug 30, 2024
View reviewed changes
cshfang
cshfang previously approved these changes Aug 30, 2024
View reviewed changes
@Samaritan1011001 Samaritan1011001 dismissed stale reviews from israx, HuiSF, and cshfang via 26a4920 September 3, 2024 19:23
@Samaritan1011001 Samaritan1011001 merged commit e8fb997 into main Sep 3, 2024
30 checks passed
@Samaritan1011001 Samaritan1011001 mentioned this pull request Sep 4, 2024
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllanZhengYP AllanZhengYP AllanZhengYP left review comments

@ashika112 ashika112 ashika112 left review comments

@jimblanc jimblanc jimblanc approved these changes

@HuiSF HuiSF HuiSF approved these changes

@cshfang cshfang cshfang left review comments

@israx israx israx left review comments

@ukhan-amazon ukhan-amazon Awaiting requested review from ukhan-amazon ukhan-amazon is a code owner

@haverchuck haverchuck Awaiting requested review from haverchuck haverchuck is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Samaritan1011001 @jimblanc @cshfang @AllanZhengYP @HuiSF @israx @ashika112