Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore] Enable Integ test and tagged release on Multi-bucket work #13619

Merged
merged 2 commits into from
Jul 19, 2024
Merged

[Chore] Enable Integ test and tagged release on Multi-bucket work #13619

merged 2 commits into from
Jul 19, 2024

Conversation

ashika112
Copy link
Member

@ashika112 ashika112 commented Jul 19, 2024 •
edited
Loading

Description of changes

  • This PR enables integ test and tagged release on Multi-bucket branch
  • Also adds minor comment improvement on copy assertion to make it clear

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ashika112 ashika112 merged commit 043d913 into aws-amplify:feat/multi-bucket Jul 19, 2024
28 checks passed
@ashika112 ashika112 deleted the chore/enable-integ branch July 19, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HuiSF HuiSF HuiSF approved these changes

@ashwinkumar6 ashwinkumar6 ashwinkumar6 approved these changes

@ukhan-amazon ukhan-amazon Awaiting requested review from ukhan-amazon ukhan-amazon is a code owner

@haverchuck haverchuck Awaiting requested review from haverchuck haverchuck is a code owner

@cshfang cshfang Awaiting requested review from cshfang cshfang is a code owner

@jimblanc jimblanc Awaiting requested review from jimblanc jimblanc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashika112 @HuiSF @ashwinkumar6