Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add W3693 for aurora cluster properties #3695

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Sep 17, 2024

Issue #, if available:
fix #3693
Description of changes:

  • Add W3693 for aurora serverless v1 cluster properties
  • Move PerformanceInsightsEnabled, PerformanceInsightsKmsKeyId, PerformanceInsightsRetentionPeriod from E3693 to W3693

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 94.44444% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.67%. Comparing base (8992c81) to head (b614e9e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...lint/rules/resources/rds/DbClusterAuroraWarning.py 94.44% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3695      +/-   ##
==========================================
- Coverage   93.67%   93.67%   -0.01%     
==========================================
  Files         359      360       +1     
  Lines       12262    12280      +18     
  Branches     2629     2631       +2     
==========================================
+ Hits        11487    11503      +16     
  Misses        429      429              
- Partials      346      348       +2     
Flag Coverage Δ
unittests 93.61% <94.44%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit 39c5a1a into aws-cloudformation:main Sep 17, 2024
22 checks passed
@kddejong kddejong deleted the fix/issue/3693 branch September 17, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E3693 - PerformanceInsightsEnabled not recognised as valid attribute for DB Cluster
1 participant