fix: parameters nuget icon #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #271 +/- ##
========================================
Coverage 62.58% 62.58%
========================================
Files 61 61
Lines 2627 2627
========================================
Hits 1644 1644
Misses 983 983
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hjgraca
reviewed
May 12, 2023
version.json
Outdated
| @@ -6,6 +6,6 @@ | |||
| "Tracing": "1.1.0" | |||
| }, | |||
| "Utilities": { | |||
| "Parameters": "0.0.1-preview" | |||
| "Parameters": "0.0.2-preview" | |||
There was a problem hiding this comment.
Do we need to update the version? There are no code changes. If we push to nuget does it not update if the version is there already?
There was a problem hiding this comment.
There is a change in dll metadata at least, we are deploying a new NuGet package, and our deployment are immutable.
There was a problem hiding this comment.
Removed the version change, icon will be fixed with next release.
hjgraca
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #270
Summary
Changes
This PR adds AWS Icon to the Parameters NuGet Package
User experience
Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.