Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Include symbols in nuget package for debugging #346

Closed
wants to merge 3 commits into from

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Jul 6, 2023

Please provide the issue number

Issue number: #345

Summary

A good debugging experience relies on the presence of debug symbols as they provide critical information like the association between the compiled and the source code, names of local variables, stack traces, and more. You can use symbol packages (.snupkg) to distribute these symbols and improve the debugging experience of your NuGet packages.
Symbol package isn't the only strategy to make the debug symbols available to the consumers of your library. It's also possible to include the PDB in the main NuGet package.

Changes

Please provide a summary of what's being changed

Include AllowedOutputExtensionsInPackageBuildOutputFolder in csproj

<AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder>

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested a review from amirkaws July 6, 2023 15:38
@boring-cyborg boring-cyborg bot added area/idempotency area/logging Core logging utility labels Jul 6, 2023
@auto-assign auto-assign bot requested a review from sliedig July 6, 2023 15:38
@boring-cyborg boring-cyborg bot added area/metrics Core metrics utility area/parameters area/tracing Core tracing utility labels Jul 6, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 6, 2023
@hjgraca hjgraca linked an issue Jul 6, 2023 that may be closed by this pull request
1 task
@github-actions github-actions bot added the internal Maintenance changes label Jul 6, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/idempotency area/logging Core logging utility area/metrics Core metrics utility area/parameters area/tracing Core tracing utility internal Maintenance changes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Improve debugging experience
1 participant