Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor and simplify Common dependency. #643

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Sep 2, 2024

Please provide the issue number

Issue number: #626

Summary

Changes

This is the final approach for #641

  • Removed Directory.build.targets
  • Simple Common project reference when on debug. This allows to reference the project in other projects without the need to reference Common
  • NuGet packages are packaged with all the code needed from Common and JMESPath (in Idempotency)
  • In projects that need Common add <IncludeCommonFiles>true</IncludeCommonFiles>

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested a review from amirkaws September 2, 2024 13:57
@boring-cyborg boring-cyborg bot added area/logging Core logging utility area/metrics Core metrics utility area/parameters labels Sep 2, 2024
@auto-assign auto-assign bot requested a review from sliedig September 2, 2024 13:57
@boring-cyborg boring-cyborg bot added the area/tracing Core tracing utility label Sep 2, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 2, 2024
@github-actions github-actions bot added the internal Maintenance changes label Sep 2, 2024
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 2, 2024
Copy link

sonarcloud bot commented Sep 2, 2024

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.76%. Comparing base (63c740f) to head (198a539).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #643      +/-   ##
===========================================
- Coverage    72.78%   72.76%   -0.03%     
===========================================
  Files          190      190              
  Lines         7886     7886              
  Branches       850      850              
===========================================
- Hits          5740     5738       -2     
- Misses        1857     1859       +2     
  Partials       289      289              
Flag Coverage Δ
unittests 72.76% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@amirkaws amirkaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hjgraca hjgraca merged commit d99a3e0 into aws-powertools:develop Sep 2, 2024
7 of 8 checks passed
@hjgraca hjgraca deleted the fix(dependencies)-Fix-Common-dependency branch September 2, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/idempotency area/logging Core logging utility area/metrics Core metrics utility area/parameters area/tracing Core tracing utility internal Maintenance changes size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants