Docs: unable to clone & install for development #415
Assignees
Labels
documentation
Improvements or additions to documentation
not-a-bug
New and existing bug reports incorrectly submitted as bug
rejected
This is something we will not be working on. At least, not in the measurable future
Milestone
Comments
dreamorosi
added
bug
|
Following Makefile works for me now when i run dev:
cd packages/commons; npm ci
cd packages/logger; npm ci
cd packages/metrics; npm ci
cd packages/tracing; npm ci
npm ci
npm run init-environment |
michaelbrewer
added a commit
to michaelbrewer/aws-lambda-powertools-typescript
that referenced
this issue
Jan 5, 2022
Changes: - Update CONTRIBUTING.md to use > aws-lambda-powertools-typescript@0.0.1 preinstall > (cd packages/commons && npm ci); (cd packages/logger && npm ci); (cd packages/metrics && npm ci); (cd packages/tracing && npm ci); > @aws-lambda-powertools/commons@0.2.0 prepare > npm run build > @aws-lambda-powertools/commons@0.2.0 build > tsc added 586 packages, and audited 587 packages in 4s 84 packages are looking for funding run `npm fund` for details found 0 vulnerabilities > @aws-lambda-powertools/logger@0.2.0 prepare > npm run build > @aws-lambda-powertools/logger@0.2.0 build > tsc added 488 packages, and audited 489 packages in 4s 72 packages are looking for funding run `npm fund` for details found 0 vulnerabilities > @aws-lambda-powertools/metrics@0.2.0 prepare > npm run build > @aws-lambda-powertools/metrics@0.2.0 build > tsc added 822 packages, and audited 852 packages in 10s 91 packages are looking for funding run `npm fund` for details found 0 vulnerabilities > @aws-lambda-powertools/tracer@0.2.0 prepare > npm run build > @aws-lambda-powertools/tracer@0.2.0 build > tsc added 836 packages, and audited 859 packages in 8s 72 packages are looking for funding run `npm fund` for details found 0 vulnerabilities added 1327 packages, removed 2761 packages, changed 10 packages, and audited 1383 packages in 40s 100 packages are looking for funding run `npm fund` for details found 0 vulnerabilities - Add a preinstall task to install all of the sub packages closes aws-powertools#415
|
A fix is up, to confirm it works just run: |
michaelbrewer
added a commit
to michaelbrewer/aws-lambda-powertools-typescript
that referenced
this issue
Jan 5, 2022
Changes: - Update CONTRIBUTING.md to use npm ci - Add a preinstall task to install all of the sub packages closes aws-powertools#415
|
Looks like the packages don't know how to build their references. // packages/metrics/tsconfig.json
"references": [
{
"path": "../commons"
}
]Use this to declare a list of modules this package depends on. When running When using vscode it does this in a background thread continuously to maintain accurate intellisense. I can put a PR in for this, as it's probably the long term fix, over maintaining a topographical build command. |
|
@simonireilly - cool. i just wanted a fix to allow for people to work from the project :) |
Totally, user experience and pragmatism first 🙏 |
|
@simonireilly - i updated the PR to make the project references work @dreamorosi PR is ready to review |
dreamorosi
pushed a commit
that referenced
this issue
Jan 12, 2022
* fix(build): Update contributing.md and fix npm ci Changes: - Update CONTRIBUTING.md to use > aws-lambda-powertools-typescript@0.0.1 preinstall > (cd packages/commons && npm ci); (cd packages/logger && npm ci); (cd packages/metrics && npm ci); (cd packages/tracing && npm ci); > @aws-lambda-powertools/commons@0.2.0 prepare > npm run build > @aws-lambda-powertools/commons@0.2.0 build > tsc added 586 packages, and audited 587 packages in 4s 84 packages are looking for funding run `npm fund` for details found 0 vulnerabilities > @aws-lambda-powertools/logger@0.2.0 prepare > npm run build > @aws-lambda-powertools/logger@0.2.0 build > tsc added 488 packages, and audited 489 packages in 4s 72 packages are looking for funding run `npm fund` for details found 0 vulnerabilities > @aws-lambda-powertools/metrics@0.2.0 prepare > npm run build > @aws-lambda-powertools/metrics@0.2.0 build > tsc added 822 packages, and audited 852 packages in 10s 91 packages are looking for funding run `npm fund` for details found 0 vulnerabilities > @aws-lambda-powertools/tracer@0.2.0 prepare > npm run build > @aws-lambda-powertools/tracer@0.2.0 build > tsc added 836 packages, and audited 859 packages in 8s 72 packages are looking for funding run `npm fund` for details found 0 vulnerabilities added 1327 packages, removed 2761 packages, changed 10 packages, and audited 1383 packages in 40s 100 packages are looking for funding run `npm fund` for details found 0 vulnerabilities - Add a preinstall task to install all of the sub packages closes #415 * fix(build): Update contributing.md and fix npm ci Changes: - Update CONTRIBUTING.md to use npm ci - Add a preinstall task to install all of the sub packages closes #415 * chore: leave as npm install for now * fix(all): setup up project references * docs: update to use npm ci
|
dreamorosi
removed
the
triage
dreamorosi
added
documentation
dreamorosi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug description
Reported by @michaelbrewer on the Slack Dev channel.
Unable to install package after clean clone of repo, see screenshot above.
Expected Behavior
Be able to
git clone ...&npm install.Current Behavior
Throws an error for missing import of
@aws-lambda-powertools/commons(see screenshot).Possible Solution
N/A
Steps to Reproduce
git clonenpm iEnvironment
Running on Apple Silicon
Related issues, RFCs
N/A
The text was updated successfully, but these errors were encountered: