Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): publish workflow concurrency + leftover dependencies #1054

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

dreamorosi
Copy link
Contributor

Description of your changes

While working on #1053, the PR #1052 introduced a small bug that prevented the last step of the publishing process (the one for the docs) to run as it was incorrectly set as part of the same concurrency group of the workflow that was calling it.

Additionally, there was a leftover dependency from a previous iteration that prevented another workflow to complete.

Both issues are fixed, when merged this PR will close #1053.

How to verify this change

See workflow run on merge or on release.

Related issues, RFCs

Issue number: #1053

PR status

Is this ready for review?: YES
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

Breaking change checklist

N/A


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dreamorosi dreamorosi added bug Something isn't working automation This item relates to automation labels Aug 12, 2022
@dreamorosi dreamorosi self-assigned this Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: docs should not be published at each commit in a PR but only when merged
3 participants