Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Pulumi code to deploy lambda with powertools #1135

Merged
merged 3 commits into from
Oct 27, 2022

Conversation

pierskarsenbarg
Copy link
Contributor

Description of your changes

Added code snippet to show how to deploy lambda with the powertools layer using Pulumi

How to verify this change

image

Related issues, RFCs

Issue number:

PR status

Is this ready for review?: NO
Is it a breaking change?: NO

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding changes to the examples
  • My changes generate no new warnings
  • The code coverage hasn't decreased
  • I have added tests that prove my change is effective and works
  • New and existing unit tests pass locally and in Github Actions
  • Any dependent changes have been merged and published in downstream module
  • The PR title follows the conventional commit semantics

Breaking change checklist

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
@leandrodamascena
Copy link
Contributor

Hi @dreamorosi and @pierskarsenbarg, I added some suggestions just to make things clearer. Please check if it makes sense.

Btw, I executed this code locally and is working as expected. Thanks @pierskarsenbarg!

pierskarsenbarg and others added 2 commits October 26, 2022 16:07
Co-authored-by: Leandro Damascena <leandro.damascena@gmail.com>
Co-authored-by: Leandro Damascena <leandro.damascena@gmail.com>
@dreamorosi
Copy link
Contributor

Thank you @pierskarsenbarg for contributing this sample!

and thank you @leandrodamascena for the review.

@dreamorosi dreamorosi merged commit 6dc2bef into aws-powertools:main Oct 27, 2022
@dreamorosi dreamorosi added the documentation Improvements or additions to documentation label Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants