Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): fix alias in versions.json #1576

Merged
merged 1 commit into from
Jul 4, 2023
Merged

fix(docs): fix alias in versions.json #1576

merged 1 commit into from
Jul 4, 2023

Conversation

sthulb
Copy link
Contributor

@sthulb sthulb commented Jul 4, 2023

Description of your changes

Before:
After a docs upload to S3, the version picker would be out of date.

After:
The version picker will contain the newest version number.

Related issues, RFCs

Issue number: None

Checklist

  • My changes meet the tenets criteria
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in areas that should be flagged with a TODO, or hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my change is effective and works
  • The PR title follows the conventional commit semantics

Breaking change checklist

Is it a breaking change?: NO

  • I have documented the migration process
  • I have added, implemented necessary warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@sthulb sthulb requested a review from a team as a code owner July 4, 2023 11:06
@boring-cyborg boring-cyborg bot added the automation This item relates to automation label Jul 4, 2023
@pull-request-size pull-request-size bot added the size/XS PR between 0-9 LOC label Jul 4, 2023
@github-actions github-actions bot added the bug Something isn't working label Jul 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure.

@github-actions github-actions bot added do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels Jul 4, 2023
@am29d am29d removed do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels Jul 4, 2023
@am29d am29d merged commit 7198cbc into main Jul 4, 2023
11 checks passed
@am29d am29d deleted the fix-docs-alias branch July 4, 2023 11:26
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

@aws-powertools/lambda-typescript No related issues found. Please ensure 'status/pending-release' label is applied before releasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation This item relates to automation bug Something isn't working size/XS PR between 0-9 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants