-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(commons): add fromBase64 helper function #2190
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
commons
This item relates to the Commons Utility
dependencies
Changes that touch dependencies, e.g. Dependabot, etc.
tests
PRs that add or change tests
labels
Mar 8, 2024
2 tasks
github-actions
bot
added
the
feature
PRs that introduce new features or minor changes
label
Mar 8, 2024
dreamorosi
removed
dependencies
Changes that touch dependencies, e.g. Dependabot, etc.
tests
PRs that add or change tests
labels
Mar 8, 2024
am29d
requested changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, I have only a minor question about the export path.
am29d
approved these changes
Mar 11, 2024
boring-cyborg
bot
added
dependencies
Changes that touch dependencies, e.g. Dependabot, etc.
tests
PRs that add or change tests
labels
Mar 11, 2024
Quality Gate passedIssues Measures |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
commons
This item relates to the Commons Utility
dependencies
Changes that touch dependencies, e.g. Dependabot, etc.
feature
PRs that introduce new features or minor changes
size/L
PRs between 100-499 LOC
tests
PRs that add or change tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This PR introduces a new helper function in the common package dedicated to decoding a base64 encoded string to a byte array.
I am adding the utility here because it will be used by both the upcoming JMESPath utility as well as the existing Parameters one.
The helper function is exposed via subpath and dedicated export, so in most cases it will be tree shaken at bundle time when not used.
Related issues, RFCs
Issue number: #2188
Checklist
Breaking change checklist
Is it a breaking change?: NO
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.