Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix - overlaywith top/left return int after percent conversion #276

Closed
wants to merge 1 commit into from

Conversation

njtmead
Copy link

@njtmead njtmead commented Mar 25, 2021

Issue #, if available:

254

Description of changes:

convert left and top to int after percentage based calculation which can potentially return float which throws an error.

Checklist

  • 👋 I have run the unit tests, and all unit tests have passed.
  • ⚠️ This pull request might incur a breaking change.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@beomseoklee
Copy link
Member

Thanks for your contribution, @njtmead
We have put this one into our backlog item, and we will get back to you.

@fisenkodv
Copy link
Contributor

@njtmead, thank you for your contribution.
We have updated our solution, and your pull request has been merged into our main branch. However, as we've merged many pull requests at this time, the source code might not exactly same as what you've done. In addition, due to our internal process, we've merged source code manually, so please understand how your effort has been merged.

You can refer to the recent changes here.

@fisenkodv fisenkodv closed this Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants