Expose EMF TCP and UDP ports, and others, in the service #182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Currently the operator creates a service for the agent with a fixed set of ports, without taking into account the agent configuration. That means adding
emf: {}
to the cwagent config will make the container listen to the ports 25888 tcp and udp, but the service does not add these ports.The change does a little bit of refactoring to make the service ports the same as the container ports. I've split the commits to be more readable:
getContainerPorts
function is made self-contained and it's moved to the ports.go file. This is not changing functionality, it's just moving it around.getContainerPorts
into ServicePorts.Manual testing:
This is an example k8s service having the ports 25888 for EMF when using the new operator image:
And the CWA container ports:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.