Support configurable resources for NodeJS. #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
NodeJS support was recently implemented: #220 & aws-observability/helm-charts#91. This change allows support for configurable resources for NodeJS init containers likewise to the #196 changes.
Testing
Ran
make testand all unit tests were passing.Manual testing
helm upgrade --install amazon-cloudwatch-observability helm-charts/charts/amazon-cloudwatch-observability --values helm-charts/charts/amazon-cloudwatch-observability/values.yaml --set clusterName=<cluster-name> --set region=<region> --set manager.autoInstrumentationResources.nodejs.limits.cpu=200m --set manager.autoInstrumentationResources.nodejs.limits.memory=512Mi --set manager.autoInstrumentationResources.nodejs.requests.cpu=200m --set manager.autoInstrumentationResources.nodejs.requests.memory=51Mikubectl edit deployment amazon-cloudwatch-observability-controller-managerkubectl apply -f amazon-cloudwatch-agent-operator/integration-tests/nodejs/sample-deployment-nodejs.yamlkubectl get podskubectl describe pod nginx-XXXXXXXXXX-XXXXXTest case
helm upgrade --install amazon-cloudwatch-observability helm-charts/charts/amazon-cloudwatch-observability --values helm-charts/charts/amazon-cloudwatch-observability/values.yaml --set clusterName=<cluster-name> --set region=<region> --set manager.autoInstrumentationResources.nodejs.limits.cpu=200m --set manager.autoInstrumentationResources.nodejs.limits.memory="" --set manager.autoInstrumentationResources.nodejs.requests.cpu=200m --set manager.autoInstrumentationResources.nodejs.requests.memory=51MiBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.