Update AppSignals configuration: 1) disable Logs exporter; 2) use http endpoint #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangzlei
changed the title
zzhlogin
approved these changes
Feb 23, 2024
lisguo
approved these changes
Feb 23, 2024
sky333999
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
1. Disable OTel logs exporter
From OTel Java v2.0.0, the OTLP Logs exporter changes to default on.
Since AppSignals does not provide logs to customer, the current AppSignals configuration does not have logs endpoints. It causes the default on logs exporter prints an error log like "cannot create connection for logs exporter, xxxxx".
To ensure this error log does not distract customer, we will disable the log exporter explicitly by OTEL environment variable
OTEL_LOGS_EXPORTER.2. Use http endpoint instead of grpc
From March 2024, AppSignals java and python support transport protocol both http and grpc. Http is default in OTel spec so we use Http endpoints in operator.
The changes is for AppSignals EKS only. For ECS and EC2 customers we provide this configuration in user guide.
Description of changes:
set OTEL_LOGS_EXPORTER=none
set OTEL_AWS_APP_SIGNALS_EXPORTER_ENDPOINT=http://cloudwatch-agent.amazon-cloudwatch:4316/v1/metrics
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.