-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] feat: Support runtime metrics #1306
Open
adebayor123
wants to merge
3
commits into
aws:main
Choose a base branch
from
adebayor123:runtime-metrics
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adebayor123
changed the title
feat: Add runtime metrics to AppSignals exporter config
[DRAFT]feat: Add runtime metrics to AppSignals exporter config
Aug 16, 2024
adebayor123
changed the title
[DRAFT]feat: Add runtime metrics to AppSignals exporter config
feat: Add runtime metrics to AppSignals exporter config
Aug 16, 2024
adebayor123
force-pushed
the
runtime-metrics
branch
from
August 16, 2024 20:06
d9fe486
to
4dd5566
Compare
bjrara
reviewed
Aug 16, 2024
translator/translate/otel/exporter/awsemf/appsignals_config_generic.yaml
Outdated
Show resolved
Hide resolved
adebayor123
force-pushed
the
runtime-metrics
branch
8 times, most recently
from
August 26, 2024 17:08
96cb92a
to
96b3fce
Compare
adebayor123
force-pushed
the
runtime-metrics
branch
from
August 26, 2024 23:07
96b3fce
to
1f1b217
Compare
This PR was marked stale due to lack of activity. |
adebayor123
force-pushed
the
runtime-metrics
branch
from
September 4, 2024 22:29
914dc74
to
0a8dec3
Compare
adebayor123
changed the title
feat: Add runtime metrics to AppSignals exporter config
feat: Support runtime metrics
Sep 4, 2024
bjrara
reviewed
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please evaluate whether to use mean
or sum
in the aggregation_type
.
plugins/processors/awsapplicationsignals/internal/normalizer/attributesnormalizer.go
Outdated
Show resolved
Hide resolved
...slate/otel/processor/appsignalsmetricstransformprocessor/config/appSignalsRuntimeConfig.yaml
Outdated
Show resolved
Hide resolved
...slate/otel/processor/appsignalsmetricstransformprocessor/config/appSignalsRuntimeConfig.yaml
Show resolved
Hide resolved
...slate/otel/processor/appsignalsmetricstransformprocessor/config/appSignalsRuntimeConfig.yaml
Outdated
Show resolved
Hide resolved
adebayor123
force-pushed
the
runtime-metrics
branch
from
September 10, 2024 03:15
38d296b
to
3489a58
Compare
This was referenced Sep 13, 2024
bjrara
reviewed
Sep 17, 2024
plugins/processors/awsapplicationsignals/internal/normalizer/attributesnormalizer.go
Outdated
Show resolved
Hide resolved
plugins/processors/awsapplicationsignals/internal/prune/metric_pruner.go
Outdated
Show resolved
Hide resolved
adebayor123
force-pushed
the
runtime-metrics
branch
from
September 17, 2024 19:06
f0d731f
to
abbc3a5
Compare
adebayor123
changed the title
feat: Support runtime metrics
[DO NOT MERGE] feat: Support runtime metrics
Sep 18, 2024
adebayor123
force-pushed
the
runtime-metrics
branch
from
September 18, 2024 20:52
abbc3a5
to
3472310
Compare
This PR was marked stale due to lack of activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant PR:
Description of the issue
ApplicationSignals is expanding the set of monitored metrics to include runtime metrics.
Description of changes
This pull request contains changes required to support runtime metrics in CWAgent for ApplicationSignals. To enable the change, we are introducing a new processor,
metrictransformprocessor
, and expanding the exporter config to handle JVM and Python runtime metrics.License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
make test
& manual testingRequirements
Before commit the code, please do the following steps.
make fmt
andmake fmt-sh
make lint