Skip to content

Commit

Permalink
chore(cli): fix integ test for IAM diff (#8316)
Browse files Browse the repository at this point in the history
following on from #8274 where a broken integ test that never ran was fixed.
A different test for the IAM diff was verifying previously incorrect service
principal and we missed updating the expectation.

This fixes up the expectations to align to the changes made in #8274 and
uses the corrected service principal (ec2.amazonaws.com).

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
shivlaks authored Jun 2, 2020
1 parent 171b039 commit e257dc8
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/aws-cdk/test/integ/cli/cli.integtest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -440,12 +440,12 @@ test('IAM diff', async () => {
// ┌───┬─────────────────┬────────┬────────────────┬────────────────────────────┬───────────┐
// │ │ Resource │ Effect │ Action │ Principal │ Condition │
// ├───┼─────────────────┼────────┼────────────────┼────────────────────────────┼───────────┤
// │ + │ ${SomeRole.Arn} │ Allow │ sts:AssumeRole │ Service:ec2.amazon.aws.com │ │
// │ + │ ${SomeRole.Arn} │ Allow │ sts:AssumeRole │ Service:ec2.amazonaws.com │ │
// └───┴─────────────────┴────────┴────────────────┴────────────────────────────┴───────────┘

expect(output).toContain('${SomeRole.Arn}');
expect(output).toContain('sts:AssumeRole');
expect(output).toContain('ec2.amazon.aws.com');
expect(output).toContain('ec2.amazonaws.com');
});

test('fast deploy', async () => {
Expand Down

0 comments on commit e257dc8

Please sign in to comment.