Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws-lambda-python] example code does not work, using wrong libraries #10229

Closed
justin8 opened this issue Sep 8, 2020 · 2 comments · Fixed by #10254
Closed

[aws-lambda-python] example code does not work, using wrong libraries #10229

justin8 opened this issue Sep 8, 2020 · 2 comments · Fixed by #10254
Assignees
@eladb
Labels
@aws-cdk/aws-lambda-python documentation This is a problem with documentation. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md in-progress This issue is being actively worked on. p2

Comments

@justin8
Copy link
Contributor

justin8 commented Sep 8, 2020

link to reference doc page: https://docs.aws.amazon.com/cdk/api/latest/docs/aws-lambda-python-readme.html

describe your issue:

The docs refer to lambda.PythonFunction when that is a part of the aws-lambda-python module and not aws-lambda. Then 3 lines later refer to lambda.Runtime.PYTHON_3_6 when that is a part of the aws-lambda module. So it seems for this code to work you must import both aws-lambda-python and aws-lambda in the same namespace of lambda

This is a 📕 documentation issue
@justin8 justin8 added documentation This is a problem with documentation. feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 8, 2020
@eladb
Copy link
Contributor

eladb commented Sep 8, 2020

Thanks for reporting. Would be happy to take a contribution for a fix

@eladb eladb added effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p2 labels Sep 8, 2020
@SomayaB SomayaB removed the needs-triage This issue or PR still needs to be triaged. label Sep 8, 2020
@justin8 justin8 mentioned this issue Sep 8, 2020
Merged
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Sep 9, 2020
@mergify mergify bot closed this as completed in #10254 Oct 2, 2020
mergify bot pushed a commit that referenced this issue Oct 2, 2020
@justin8
docs(lambda-python): error in documented example (#10254)
69c9c73 
Closes #10229

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Oct 2, 2020

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eladb eladb

Labels
@aws-cdk/aws-lambda-python documentation This is a problem with documentation. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md in-progress This issue is being actively worked on. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(lambda-python): error in documented example justin8/aws-cdk
3 participants
@eladb @justin8 @SomayaB