Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-eks] Graduate to Developer Preview #10364

Closed
iliapolo opened this issue Sep 15, 2020 · 0 comments · Fixed by #10518
Closed

[aws-eks] Graduate to Developer Preview #10364

iliapolo opened this issue Sep 15, 2020 · 0 comments · Fixed by #10518
Assignees
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p1

Comments

@iliapolo
Copy link
Contributor

This issue will mark the graduation of this module to developer preview.

@iliapolo iliapolo added feature-request A feature should be added or improved. guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels Sep 15, 2020
@iliapolo iliapolo added this to the EKS Dev Preview milestone Sep 15, 2020
@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Sep 15, 2020
@iliapolo iliapolo added effort/small Small work item – less than a day of effort p1 and removed guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels Sep 15, 2020
@iliapolo iliapolo added the in-progress This issue is being actively worked on. label Sep 24, 2020
@mergify mergify bot closed this as completed in #10518 Sep 29, 2020
mergify bot pushed a commit that referenced this issue Sep 29, 2020
Graduate the module to *Developer Preview*.

This PR also includes some last minute API changes we feel make it a little more semantically clear.

In addition, the README was restructured to be more coherent. See [rendered version](https://github.com/aws/aws-cdk/blob/epolon/10364-eks-dev-preview/packages/%40aws-cdk/aws-eks/README.md).

Happy to break this down to multiple PR's if you find it hard to review.

BREAKING CHANGE: `cluster.addChart` renamed to `cluster.addHelmChart`

* **eks:** `NodegroupOptions.launchTemplate` renamed to `NodegroupOptions.launchTemplateSpec`
* **eks:** `cluster.addAutoScalingGroup` renamed to `cluster.connectAutoScalingGroupCapacity`
* **eks:** `cluster.addNodegroup` renamed to `cluster.addNoedgroupCapacity`
* **eks:** `cluster.addCapacity` renamed to `cluster.addAutoScalingGroupCapacity`
* **eks:** `CapacityOptions` renamed to `AutoScalingGroupCapacityOptions`.

Resolves #10364

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant