Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[s3] support s3:ObjectRestore:Completed event type #10498

Closed
2 tasks
mauricioharley opened this issue Sep 23, 2020 · 1 comment · Fixed by #10552
Closed
2 tasks

[s3] support s3:ObjectRestore:Completed event type #10498

mauricioharley opened this issue Sep 23, 2020 · 1 comment · Fixed by #10552
Assignees
Labels
@aws-cdk/aws-s3 Related to Amazon S3 effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p1

Comments

@mauricioharley
Copy link

I'm building a solution for a customer that leverages S3 data events. More specifically, it relies on the s3:ObjectRestore:Completed event. According to the CDK Python documentation, it seems this event type is not supported:

https://docs.aws.amazon.com/cdk/api/latest/python/aws_cdk.aws_s3/EventType.html

I can't understand why nearly all event types are supported, but this one. It would be nice if we could have this in the CDK code itself, instead of having to look for workarounds, such as using CloudFormation templates.

Any possible roadmaps to share on this, or eventual workarounds?

Use Case

The solution works smoothly considering CloudFormation (or even Terraform). The use case follows as an image attached to this feature request.

Proposed Solution

Some temporary workaround. Open to suggestions.

Other

I'm facing problems when trying to code this ("notify_lambda" corresponds to Lambda function B):

destination_bucket.add_event_notification(
s3.EventType.RESTORE_COMPLETED,
s3_notifications.LambdaDestination(self.notify_lambda)
)

TEMP - Restore Objects

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@mauricioharley mauricioharley added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 23, 2020
@SomayaB SomayaB changed the title [CDK Python S3] [s3] support s3:ObjectRestore:Completed event type Sep 23, 2020
@SomayaB SomayaB added the language/python Related to Python bindings label Sep 23, 2020
@github-actions github-actions bot added the @aws-cdk/aws-s3 Related to Amazon S3 label Sep 23, 2020
@rrhodes
Copy link
Contributor

rrhodes commented Sep 26, 2020

Hello, I'm looking into this now and hope to have a PR open shortly.

@iliapolo iliapolo added effort/small Small work item – less than a day of effort p1 and removed language/python Related to Python bindings needs-triage This issue or PR still needs to be triaged. labels Sep 26, 2020
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Sep 29, 2020
@mergify mergify bot closed this as completed in #10552 Sep 29, 2020
mergify bot pushed a commit that referenced this issue Sep 29, 2020
…#10552)

Adding support for [additional S3 notification event types](https://docs.aws.amazon.com/AmazonS3/latest/dev/NotificationHowTo.html#supported-notification-event-types), including 's3:ObjectRestore:Completed' recently raised by @mauricioharley as a feature request.

Closes #10498

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-s3 Related to Amazon S3 effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants