Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cli] CDKMetada resource warning #10625

Closed
kyler-hyuna opened this issue Oct 1, 2020 · 6 comments · Fixed by #10695
Closed

[cli] CDKMetada resource warning #10625

kyler-hyuna opened this issue Oct 1, 2020 · 6 comments · Fixed by #10695
Assignees
@rix0rrr
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort needs-triage This issue or PR still needs to be triaged. p1 package/tools Related to AWS CDK Tools or CLI

Comments

@kyler-hyuna
Copy link

❓ General Issue

Hey, I'm seeing this warning anytime I run a diff or deploy command. Is there any way to remove this warning?

The stack <stack-name> already includes a CDKMetadata resource

Environment

  • CDK CLI Version: 1.65.0
  • Module Version: 1.65.0
  • Node.js Version: v14.9.0
  • OS: macOS Catalina
  • Language (Version): TypeScript (3.9.7)
@kyler-hyuna kyler-hyuna added guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels Oct 1, 2020
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Oct 1, 2020
@skyrpex
Copy link
Contributor

skyrpex commented Oct 2, 2020

I'm getting this as well, and can't generate generate the cloud formation YML without deleting the first line 🤔

I'm also using the same versions except for Typescript 4.0.3.

@DreAmigo
Copy link

DreAmigo commented Oct 2, 2020 •
edited
Loading

Getting this as well.

Environment

  • CDK CLI Version: 1.65.0
  • Module Version: 1.65.0
  • Node.js Version: v13.13.0
  • OS: macOS Catalina 10.15.6 (19G2021)
  • Language (Version): TypeScript (4.0.2)

@shivlaks shivlaks mentioned this issue Oct 3, 2020
Closed
@informity
Copy link

Getting the same thing:

Environment

  • CDK CLI Version: 1.66.0 (build 459488d)
  • Module Version: 1.65.0
  • Node.js Version: v12.18.4
  • OS: MacOS Catalina 10.15.6
  • Language (Version): TypeScript (Version 4.0.3)

@colvint
Copy link

colvint commented Oct 4, 2020

This line seems to be the source of the warning:

aws-cdk/packages/aws-cdk/lib/api/cxapp/cloud-executable.ts

Line 134 in dfd2baf

warning(`The stack ${stack.id} already includes a CDKMetadata resource`);

@rix0rrr
Copy link
Contributor

rix0rrr commented Oct 5, 2020

That line is there because of an abundance of caution. I feel it can safely be removed.

rix0rrr added a commit that referenced this issue Oct 5, 2020
@rix0rrr
fix(cli): 'stack already contains Metadata resource' warning
dcd09e4 
This warning was added to detect an inability to add the metadata
resource in the CLI, before the framework started emitting the metadata
resource by default. Now it's expected, and the warning doesn't
make any sense anymore.

Fixes #10625.
@rix0rrr rix0rrr mentioned this issue Oct 5, 2020
Merged
@rix0rrr rix0rrr added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 and removed guidance Question that needs advice or information. labels Oct 5, 2020
@mergify mergify bot closed this as completed in #10695 Oct 5, 2020
mergify bot pushed a commit that referenced this issue Oct 5, 2020
@rix0rrr
fix(cli): 'stack already contains Metadata resource' warning (#10695)
e0b5508 
This warning was added to detect an inability to add the metadata
resource in the CLI, before the framework started emitting the metadata
resource by default. Now it's expected, and the warning doesn't
make any sense anymore.

Fixes #10625.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Oct 5, 2020

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort needs-triage This issue or PR still needs to be triaged. p1 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cli): 'stack already contains Metadata resource' warning aws/aws-cdk
6 participants
@colvint @DreAmigo @rix0rrr @skyrpex @kyler-hyuna @informity